fix: drop into the agent for non-allocated servers

Fixes #558 Returning 404 error to iPXE might bring some servers into the state when it takes a hard reboot to make it go back to network boot. Also in line with the future changes to boot in the long-running agent always. Signed-off-by: Andrey Smirnov <[email protected]>
siderolabs · Nov 15, 2021 · 701d01b · 701d01b
1 parent b0e3611
commit 701d01b
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/app/sidero-controller-manager/internal/ipxe/ipxe_server.go b/app/sidero-controller-manager/internal/ipxe/ipxe_server.go
@@ -31,10 +31,7 @@ import (
 	"github.com/talos-systems/sidero/app/sidero-controller-manager/pkg/constants"
 )
 
-var (
-	ErrNotInUse     = errors.New("server not in use")
-	ErrBootFromDisk = errors.New("boot from disk")
-)
+var ErrBootFromDisk = errors.New("boot from disk")
 
 // bootFile is used when iPXE is booted without embedded script via iPXE request http://endpoint:8081/boot.ipxe.
 const bootFile = `#!ipxe
@@ -140,13 +137,6 @@ func ipxeHandler(w http.ResponseWriter, r *http.Request) {
 			return
 		}
 
-		if errors.Is(err, ErrNotInUse) {
-			log.Printf("Server %q not in use, skipping", uuid)
-			w.WriteHeader(http.StatusNotFound)
-
-			return
-		}
-
 		log.Printf("%v", err)
 		w.WriteHeader(http.StatusInternalServerError)
 
@@ -296,10 +286,8 @@ func newEnvironment(server *metalv1alpha1.Server, serverBinding *infrav1.ServerB
 	switch {
 	case server == nil:
 		return newAgentEnvironment(arch), nil
-	case serverBinding == nil && !server.Status.IsClean:
-		return newAgentEnvironment(arch), nil
 	case serverBinding == nil:
-		return nil, ErrNotInUse
+		return newAgentEnvironment(arch), nil
 	case conditions.Has(server, metalv1alpha1.ConditionPXEBooted) && !server.Spec.PXEBootAlways:
 		return nil, ErrBootFromDisk
 	case server.Spec.EnvironmentRef != nil: