Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate restoring streaming request body through to upstream #176

Open
mwhitworth opened this issue Feb 24, 2024 · 0 comments
Open

Investigate restoring streaming request body through to upstream #176

mwhitworth opened this issue Feb 24, 2024 · 0 comments

Comments

@mwhitworth
Copy link
Collaborator

This functionality was effectively removed to fix #175 - the new version of this functionality should fulfil two requirements:

  • it should be tested to work with each adapter - {:stream, _} as a input value for the upstream body was supported by HTTPoison, but it was unclear (and untested) whether this was supported by the Tesla adapter at all
  • as Broken in Bandit (also silently in Cowboy) #175, we need to forward conn whenever we use Plug.Conn.read_body - but that seems to be at odds with passing in a stream to the library. Perhaps Stream.resource, and sending the latest conn to ourselves?
@mwhitworth mwhitworth mentioned this issue Feb 24, 2024
Merged
@mwhitworth mwhitworth changed the title Investigate restoring stream request body through to upstream Investigate restoring streaming request body through to upstream Feb 24, 2024
@skanderm skanderm mentioned this issue Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwhitworth