Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

talkiq/tester: Major release recommendations #67

Open
caseydialpad opened this issue Oct 4, 2021 · 1 comment
Open

talkiq/tester: Major release recommendations #67

caseydialpad opened this issue Oct 4, 2021 · 1 comment

Comments

@caseydialpad
Copy link
Contributor

The orb talkiq/tester has a compose_args parameter that may benefit from being renamed compose_options. See #66 (comment) for further discussion.
@caseydialpad caseydialpad changed the title Tester Major Release Suggestions talkiq/tester: Major release recommendations Oct 4, 2021
@shaundialpad
Copy link
Contributor

Perhaps we can allow the specification of either parameters.compose_options or parameters.compose_args for now (but not both, if circle allows for this), with a note in the description for compose_args that it will be deprecated in the next major release. That way, whoever does the next major release can simply remove deprecated code instead of introducing a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaundialpad @caseydialpad