Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 2.3.2 #105

Closed
wants to merge 4 commits into from
Closed

Conversation

debiatan
Copy link
Contributor

The Bootstrap 2.3.2 release fixes the issue reported on twbs/bootstrap#7118 (which prevents Firefox users from opening links by middle-clicking or control-clicking them). The fix does not introduce any additional change, so it won't have side effects.

@debiatan debiatan closed this Jan 13, 2014
@tshepang
Copy link

why close this

@debiatan
Copy link
Contributor Author

(I think) I messed up my pull request by inadvertently adding more commits to it (the only relevant commit is the first one). I didn't have time to figure out how to fix it, so I decided to close it so as not to leave people wondering about the real changes I was proposing.
Anyways, the diff on the first commit indicates the two tiny changes that need to be made on the codebase, so fixing them manually is an easy task if there's an interest to fix this minor glitch for firefox users.

Cheers

@tshepang
Copy link

thanks for the explanation

@talha131
Copy link
Member

@debiatan I have merged your commit into the repository using my git-fu skills. Your commit ca733da is part of the repo now. Thank you for your contribution, I hope you will keep contributing.

I messed up my pull request by inadvertently adding more commits to it (the only relevant commit is the first one)

Whenever you need to open a pull request, create a branch and commit the desired changes in it and then open pull request from the branch instead of master.

Let me know if you need any help.

@debiatan
Copy link
Contributor Author

Thanks for taking the time to pull the changes! All do it better next time!

2014/1/19 Talha Mansoor [email protected]

@debiatan https://github.com/debiatan I have merged your commit into
the repository using my git-fu skills. Your commit ca733dahttps://github.com/talha131/pelican-elegant/commit/ca733da8d2d869a718e60a92e06c8958770c8f4eis part of the repo now. Thank you for your contribution, I hope you will
keep contributing.

I messed up my pull request by inadvertently adding more commits to it
(the only relevant commit is the first one)

Whenever you need to open a pull request, create a branch and commit the
desired changes in it and then open pull request from the branch instead of
master.

Let me know if you need any help.


Reply to this email directly or view it on GitHubhttps://github.com//pull/105#issuecomment-32708913
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants