-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing icons for social links #98
Comments
Related to #52. Elegant uses Font Awesome icons for Social links. Each social site name should be picked from there minus the So Font Awesome doesn't have icons for gitorious and friendica.
😱 That will require writing a new plugin. It is out of scope of the theme.
I have an idea. I want to change the color from gray to their fav icon color on hover. I will explore it after January 1st. |
Ah, thanks for explaining. Maybe until then, we could use the generic external link icon for a fallback. http://fortawesome.github.io/Font-Awesome/icon/external-link-square/ |
Good find! We should use it. |
@silverhook I have looked into your suggestion. I have found two issues that I didn't realize when I made the above post.
I toyed with an idea of adding a third element in the
But this is inconsistent with other Pelican themes. I looked for ways to specify fallback CSS class. So that if an icon is missing, theme falls back to some other default icon. I couldn't find anything on it. I guess best way is to submit requests for the required icons to FontAwesome project. I am open to suggestions. |
Naaah, that’s fine. It’s probably enough if you just mention the fall back icon in the documentation. |
I will mention it in the documentation. |
When you do, feel free to close this issue 😸 |
@silverhook, Brian Blais shared a useful tip via email. With its help, this issue is fixed now. The tuple in (name, link, icon_name)
(name, link) |
Cool ☺ |
Hi, I have my social links like this:
but none of them is showing up. |
@shangsunset This might be a CORS issue. That seems to be what I'm seeing occasionally. |
I have added the following to the
pelicanconf.py
:but in the Social widget I can only see the icon for GitHub. The other two are just blank space (of appropriate size though). That's neither pretty nor practical.
As I understand the idea is to have the all the social links as gray icons. Would it be possible as a fallback to use the favicons of those webpages and apply a gray filter with JS/CSS over them?
The text was updated successfully, but these errors were encountered: