Page not active in the navbar if output is not the default.

[andreburgaud]

When pages are configured to show up in the navigation bar with a non default SAVE_PAGE_AS, selecting a page in the navbar does not set the corresponding page title style as active on the menu.

Configuration Example:

...
DISPLAY_PAGES_ON_MENU = True
PAGE_URL = '{slug}'
PAGE_SAVE_AS = '{slug}/index.html'
...

The resulting code for mypage, located in mypage/index.html would be something like:

<li><a href="http://example.com/mypage">My Page</a></li>

But should be:

<li class="active"><a href="http://example.com/mypage">My Page</a></li>

In base.html the comparison is made between output_file and page_url. In the example above, output_file is index.html and page_url is mypage.

Here is a possible fix, mostly taken from the simple template in pelican:

--- a/templates/base.html
+++ b/templates/base.html
@@ -60,8 +60,8 @@
                         <ul class="nav pull-right top-menu">
                             <li {% if page_name == 'index' %} class="active"{% endif %}><a href="{{ SITEURL }}">Home</a></li>
                             {% if DISPLAY_PAGES_ON_MENU %}
-                            {% for page in pages %}
-                            <li {% if output_file == page.url %} class="active"{% endif %}><a href="{{ SITEURL }}/{{ page.url }}">{{ page.title }}</a></li>
+                            {% for p in pages %}
+                            <li {% if p == page %} class="active"{% endif %}><a href="{{ SITEURL }}/{{ p.url }}">{{ p.title }}</a></li>
                             {% endfor %}
                             {% endif %}
                             <li {% if page_name == 'categories' %} class="active"{% endif %}><a href="{{ SITEURL }}/categories.html">Categories</a></li>

I tested it successfully with the default configuration for the page output and with the configuration mentioned above.

[talha131]

@andreburgaud thanks a lot for fixing this issue.