Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars don't display over post-processing sky #28

Open
shotamatsuda opened this issue Dec 16, 2024 · 3 comments
Open

Stars don't display over post-processing sky #28

shotamatsuda opened this issue Dec 16, 2024 · 3 comments
Labels
package: atmosphere Specific to @takram/three-atmosphere

Comments

@shotamatsuda
Copy link
Member

shotamatsuda commented Dec 16, 2024

Related to e31e2d2

Enabling the depth write for stars partially makes them visible, but it’s unreliable as they are rendered at the camera’s far distance.

@shotamatsuda shotamatsuda added the package: atmosphere Specific to @takram/three-atmosphere label Dec 16, 2024
@shotamatsuda
Copy link
Member Author

No, this is because irradiance is applied, so the star’s color is treated as albedo. I don’t know what normals the points have.

@shotamatsuda
Copy link
Member Author

It seems that length(viewNormal) > 1.5 reliably distinguishes stars, but don’t understand the source of these normals or if it’s device dependent.

@shotamatsuda
Copy link
Member Author

But if it’s defined behavior, we’ll need another way to distinguish stars when reconstructNormals is enabled anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: atmosphere Specific to @takram/three-atmosphere
Projects
None yet
Development

No branches or pull requests

1 participant