Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

o.t.io.TrieWriter#writeSuccinctBitVector don't have enough if conditions #43

Closed
miurahr opened this issue Oct 2, 2023 · 1 comment · Fixed by #44
Closed

o.t.io.TrieWriter#writeSuccinctBitVector don't have enough if conditions #43

miurahr opened this issue Oct 2, 2023 · 1 comment · Fixed by #44

Comments

@miurahr
Copy link
Contributor

miurahr commented Oct 2, 2023

I found that there are not enough if conditions for o.t.io.TrieWriter#writeSuccinctBitVector method.

Argument SuccinctBitVector sbv is checked by instanceof

  • BytesSuccinctBitVector
  • BytesRank0OnlySuccinctBitVector
  • BytesRank0OnlySuccinctBitVector
  • BytesRank1OnlySuccinctBitVector
  • LongsSuccinctBitVector

but it also can be

  • LongsRank0OnlySuccinctBitVector
  • LongsRank1OnlySuccinctBitVector

that become IOException.

I observed it when running TrieWriterTest with a Japanese wikipedia title data at 20230901.
@miurahr miurahr changed the title o.t.io.TrieWriter#writeSuccinctBitVector has not enough if blocks o.t.io.TrieWriter#writeSuccinctBitVector don't have enough if conditions Oct 2, 2023
@miurahr
Copy link
Contributor Author

miurahr commented Oct 2, 2023

I can say similar for TrieReader. It does not have a capability to produce LongsRank0OnlySuccinctBitVector and LongsRank1OnlySuccinctBitVector.

@miurahr miurahr mentioned this issue Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: TrieReader/Writer supports LongRanl(0|1)OnlySuccinctBitVector miurahr/trie4j
1 participant
@miurahr