-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Manual assigning label "📍 Assigned" should trigger posting a comment and assign last commenter #242
Comments
I think, we just need to add the number-of-days to our text in our action. https://github.com/JabRef/jabref/blob/ec2059af58dc7b7793e9f6e0bafc8711140cd2d7/.github/workflows/on-labeled-issue.yml#L15. This is good enough and reduces handling of special cases (e.g., if the text is already there, it should not be posted...) |
Update: On GitHub mobile it is easier to add a label than to add text. Thus, the wish changes to: Assign the last commenter and post text on label creation 😅 |
This is important if a maintaimer does not want to be notified of the issue at all. When commenting, the user is notified on each change of the issue. They need to unsubscribe. With the label approach no additional actions by the user are necessary! |
I agree with this approach!
I'm not entirely sure I understand this part. Could you clarify what you mean by "assign the last commenter and post text on label creation" and how the label approach helps in avoiding notifications? I'd love to get more context! |
Example: After the comment JabRef/jabref#4257 (comment) Thilo assigned FirstTimeContribution.This triggers GitHub to post a text. Since it was not Thilo himself, he does not get notifications, because he is not “involved“ in the conversation! |
Got it, will look into it 👍 |
Type of feature
💡 Feature
Current behavior
Currently, the label "📍 Assigned" is assigned after a command. Soemtimes, there is manual assignment necessary, which is currently not covered by the action.
Suggested solution
When someone is assigned AND the label "📍 Assigned" was assigned, the action should post the welcoming text.
I know, this is also possible by other actions (e.g., Create or Update Comment), but it would be nice to have an all-in-one solution.
Additional context
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: