This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remake of remix-run/react-router#3105.
This is not quite ready for release, as I want to make this an opt-in feature guarded behind a deprecation for now, as well as to update the documentation and examples as appropriate.
This PR changes the pattern matching algorithm from the home-grown React Router to
path-to-regexp
, which is used by Express and a number of other JavaScript routing frameworks.The biggest advantages of this change are:
This will come with a few breaking changes once the feature is enabled:
/:foo?
as with Express, rather than(/:foo)
as with RR v1+ (but this is the syntax in v0.13.x)splat
*
is a greedy splatIn other words, Express's path matching works slightly differently to React Router's.
I expect that for the majority of applications, this should be fully drop-in. For the rest, the migration work will be relatively limited.