-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
future of ComponentPropsWithoutRef and React 19 #1595
Comments
Hey! Yeah we definitely have our eyes on React 19, but given that it hasn't even officially been released yet Catalyst is going to remain a React 18 project for now. That said, I just tried using Catalyst in a React 19 project and it appeared to work, so that's good news at least for anyone wanting to use Catalyst on the bleeding-edge. But fair warning, I hardly tested this extensively 😅 Also keep in mind that not all dependencies are React 19 compatible yet, so you'll need to use the Once React 19 becomes the de facto React version we'll definitely revisit this — I for one would love to remove all the Hope that makes sense! |
I am already using catalyst with React 19 with our brand new project. So yeah... everything good. Just wanted to give you a hint there... Sorry for the noise in the bug tracker ;-) Update: of course there some browser console warnings from headlessui for instance like: But anyway.. nothing that bugs me at this point ;-) |
Sorry if this is off-topic, but would it be safe to change the component type to |
Hey folks, just a heads up that we've updated Headless UI to support React 19: tailwindlabs/headlessui#3543. You can upgrade to this latest version by running: npm install @headlessui/react@latest Note that I suspect that once React 19 is out officially (it's still just a release candidate today) that we'll upgrade Catalyst to require React 19. Not going to lie, I look forward to removing the |
What component (if applicable)
catalyst components
Describe the bug
Its not really a bug but merely a hint / suggestion
Throughout the catalyst component library, we will have the typical usage of React.ComponentPropsWithoutRef. I wonder if this apporach is still viable with the advent of React 19.
AFAIK we can safely pass in a ref as prop from the outside now and this should also be possibe with the catalyst components shouldnt it?
The text was updated successfully, but these errors were encountered: