Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Popovers no longer work on version 1.7.8 #2292

Closed
alex-ketch opened this issue Feb 17, 2023 Discussed in #2221 · 1 comment · Fixed by #2293
Closed

Nested Popovers no longer work on version 1.7.8 #2292

alex-ketch opened this issue Feb 17, 2023 Discussed in #2221 · 1 comment · Fixed by #2293

Comments

@alex-ketch
Copy link

Encountered this just now and seems like the discussion should be an issue instead.
Can try and investigate sometime over the coming weekends if desired.

Discussed in #2221

Originally posted by THowland1 January 28, 2023

Summary

With the latest update of 1.7.8, when using React 17, Popovers inside another Popover's Panel don't have IDs on the buttons, which makes them unable to open the next level down
image

Minimal Repro:

"react": "^17.0.1",
"react-dom": "^17.0.1",
"@headlessui/react": "1.7.8"
https://codesandbox.io/p/sandbox/nifty-benz-jq19yx?selection=%5B%7B%22endColumn%22%3A44%2C%22endLineNumber%22%3A2%2C%22startColumn%22%3A44%2C%22startLineNumber%22%3A2%7D%5D&file=%2Fsrc%2FApp.tsx

Another minimal repro

"react": "^18.0.1",
"react-dom": "^18.0.1",
"@headlessui/react": "1.7.8"
https://codesandbox.io/p/sandbox/charming-river-dut1og?selection=%5B%7B%22endColumn%22%3A30%2C%22endLineNumber%22%3A9%2C%22startColumn%22%3A30%2C%22startLineNumber%22%3A9%7D%5D&file=%2Fpackage.json

Working Repro (old version)

"react": "^17.0.1",
"react-dom": "^17.0.1",
"@headlessui/react": "1.7.7"
https://codesandbox.io/p/sandbox/zealous-sinoussi-68j10g?selection=%5B%7B%22endColumn%22%3A5%2C%22endLineNumber%22%3A15%2C%22startColumn%22%3A5%2C%22startLineNumber%22%3A15%7D%5D&file=%2Fpackage.json

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

Going to close this as a duplicate of #2285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants