New method Dir::sync
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It calls fsync() on the file descriptor. This is necessary with some
operating systems and/or file systems to ensure that changes to the
contents of the directory make it to persistent storage — for the same
reason it is sometimes necessary to use `std::fs::File::sync_{all,contents}`.
Note that this method will fail if used on a `Dir` opened with `O_PATH`.
(Same issue as `list_dir`; see tailhook#34.)
Closes tailhook#47.
|
@cehteh FYI, I would be interested in helping out with this crate more broadly. I see a lot of places I could supply some polish. |
You'll be welcome. I am currently busy with other things but I have some plans to improve this crate in future. Meanwhile I like help and PR adding such features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It calls fsync() on the file descriptor. This is necessary with some operating systems and/or file systems to ensure that changes to the contents of the directory make it to persistent storage — for the same reason it is sometimes necessary to use
std::fs::File::sync_{all,contents}.Note that this method will fail if used on a
Diropened withO_PATH. (Same issue aslist_dir; see tailhook#34.)Closes tailhook#47.