Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): ui fixes #489

Merged
merged 12 commits into from
Dec 30, 2022
Merged

fix(bridge): ui fixes #489

merged 12 commits into from
Dec 30, 2022

Conversation

shadab-taiko
Copy link
Contributor

@shadab-taiko shadab-taiko commented Dec 27, 2022

  • add invalid chain balance section in dropdown
  • add invalid chain icon and fix mobile view
  • open faucet in new tab
  • metamask icon
  • transaction list mobile view
  • transaction detail mobile view
  • move message status tooltip into component

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #489 (036a369) into main (d1a4921) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files         106      106           
  Lines        2843     2843           
  Branches      354      354           
=======================================
  Hits         1899     1899           
  Misses        868      868           
  Partials       76       76           
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø)
protocol 58.88% <ø> (ø) Carriedforward from 2e06ecd
relayer 69.10% <ø> (ø) Carriedforward from 2e06ecd
ui 100.00% <ø> (ø) Carriedforward from 2e06ecd

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui 🔄 Building (Inspect) Dec 29, 2022 at 6:31AM (UTC)
website 🔄 Building (Inspect) Dec 29, 2022 at 6:31AM (UTC)

dantaik
dantaik previously approved these changes Dec 28, 2022
@dionysuzx
Copy link
Collaborator

nitpick:
image
it looks like the "Pending" is a little high on the x-axis?

@dionysuzx dionysuzx requested a review from dantaik December 29, 2022 22:38
@shadab-taiko shadab-taiko merged commit 6c080cb into main Dec 30, 2022
@shadab-taiko shadab-taiko deleted the ui-fixes-2 branch December 30, 2022 14:32
dantaik pushed a commit that referenced this pull request Jan 3, 2023
* feat(bridge): add invalid chain balance section in dropdown

* feat(bridge): add invalid chain icon and fix mobile view

* fix(bridge): open faucet in new tab

* fix(bridge): metamask icon

* fix(bridge): transaction list mobile view

* fix(bridge): transaction detail mobile view

* feat(bridge): move message status tooltip into component

* Update HeaderAnnouncement.svelte

* fix(bridge): invalid chain icon alignment

* fix(bridge): status alignment

Co-authored-by: dave | d1onys1us <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants