Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bridge): Add Failed state for Bridge and releaseTokens method on TokenVault #355

Closed
cyberhorsey opened this issue Nov 29, 2022 · 3 comments · Fixed by #13008
Closed

feat(bridge): Add Failed state for Bridge and releaseTokens method on TokenVault #355

cyberhorsey opened this issue Nov 29, 2022 · 3 comments · Fixed by #13008
Assignees
@dantaik
Labels
area.protocol category.enhancement

Comments

@cyberhorsey
Copy link
Contributor

cyberhorsey commented Nov 29, 2022 •
edited
Loading

If invokeMessageCall fails, we should add a new state, FAILED, for the message on the destination chain bridge. And then we should add a releaseTokens method on the TokenVault for source chain which takes a merkle proof of the releaseTokens on the destination chain that the signal has message status = 3 (aka: FAILED).
@dantaik dantaik mentioned this issue Nov 29, 2022
Merged
@dantaik dantaik linked a pull request Nov 29, 2022 that will close this issue
chore(bridge): add a FAILED message status #356
Merged
@dantaik dantaik removed a link to a pull request Nov 29, 2022
chore(bridge): add a FAILED message status #356
Merged
@dantaik
Copy link
Contributor

dantaik commented Nov 29, 2022

FAILED status was added in PR #356 but the releaseTokens is not part of it.

@dantaik dantaik assigned dantaik and unassigned cyberhorsey Jan 3, 2023
@dantaik dantaik linked a pull request Jan 4, 2023 that will close this issue
refactor(bridge): use deterministic message status slot (w/o mapping) #6861
Merged
@dantaik dantaik moved this to 🏗 In progress in Taiko Project Board Jan 4, 2023
@dantaik dantaik removed a link to a pull request Jan 4, 2023
refactor(bridge): use deterministic message status slot (w/o mapping) #6861
Merged
@dantaik dantaik moved this from 🏗 In progress to 📝 Todo in Taiko Project Board Jan 4, 2023
@dantaik dantaik moved this from 📝 Todo to 🏗 In progress in Taiko Project Board Jan 4, 2023
@dantaik dantaik moved this from 🏗 In progress to 📝 Todo in Taiko Project Board Jan 4, 2023
@dantaik dantaik moved this from 📝 Todo to 🏗 In progress in Taiko Project Board Jan 18, 2023
@dantaik
Copy link
Contributor

dantaik commented Jan 18, 2023

After this is done, we should create an feature request issue for @shadab-taiko .

@dantaik dantaik moved this from 🏗 In progress to 📝 Todo in Taiko Project Board Jan 20, 2023
@dantaik
Copy link
Contributor

dantaik commented Jan 20, 2023

#13004 is another step before releaseToken can be implemented.

@dantaik dantaik linked a pull request Jan 22, 2023 that will close this issue
feat(protocol): implement releaseEther & releaseERC20 #13008
Merged
@dantaik dantaik moved this from 📝 Todo to 👀 In review in Taiko Project Board Jan 25, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taiko Project Board Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dantaik dantaik

Labels
area.protocol category.enhancement
Projects
Taiko Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(protocol): implement releaseEther & releaseERC20 taikoxyz/taiko-mono
2 participants
@dantaik @cyberhorsey