fix(protocol): fix permission in ComposeVerifier #18302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verifyProof function of the ComposeVerifier contract uses the onlyAuthorizedCaller modifier, which allows descendant contracts to introduce additional authorized callers. However, the verifyBatchProof function must be called by the TaikoL1 contract. This means that the verifyBatchProof function of the ZkAndTeeVerifier is not authorized to invoke the sub-verifiers and is therefore non-functional.
Consider using the onlyAuthorizedCaller modifier in both of the aforementioned cases.