-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol): reward non-assigned prover 7/8 liveness bond #18132
Conversation
fix(protocol): reward non-assigned prover 7/8 liveness bond
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Also since the proposer is paying the liveness bonds (in LibProposing): Should not we take into consideration the proposer when it comes to returning it ? Maybe it changed in the meantime, but i was in the belief that prover pays the bond, not the proposer. 🤔 (Or proposer == prover ? but i dont see this enforced anywhere ) |
The proposer and assignedProver is the same address, we named them differently because of back-ward compatible reasons. They ARE the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for some reason L2 Genesis tests seems to be failing - so disabled the auto-merge.
Without this small fix, provers other than the assigned prover won't have an incentive to prove a block out of the proving window.