-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): use SP1 1.2.0-rc with more proof verification tests #18001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smtmfft
requested review from
davidtaikocha,
dantaik and
YoGhurt111
and removed request for
davidtaikocha
August 29, 2024 13:27
smtmfft
changed the title
update sp1 dependency and add proof verify test
feat(protocol): update sp1 dependency and add proof verify test
Aug 29, 2024
feat(protocol): update sp1 dependency and add proof verify test
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
YoGhurt111
approved these changes
Aug 30, 2024
dantaik
approved these changes
Aug 30, 2024
dantaik
changed the title
feat(protocol): update sp1 dependency and add proof verify test
feat(protocol): update sp1 dependency and add proof verification test
Aug 30, 2024
dantaik
changed the title
feat(protocol): update sp1 dependency and add proof verification test
feat(protocol): use sp1 1.2.0-rc with more proof verification tests
Aug 30, 2024
dantaik
changed the title
feat(protocol): use sp1 1.2.0-rc with more proof verification tests
feat(protocol): use SP1 1.2.0-rc with more proof verification tests
Aug 30, 2024
dantaik
approved these changes
Aug 30, 2024
davidtaikocha
approved these changes
Aug 30, 2024
This was referenced Sep 9, 2024
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sp1 contract to their latest 1.2.0-rc, and add a test to make future client integration easier.