fix(protocol): refine EIP-1559 basefee calculation and gas excess adjustment in TaikoL2 #17871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
requested review from
Brechtpd,
2manslkh,
adaki2004,
k-kaddal and
davidtaikocha
fix(protocol): refine EIP-1559 basefee calculation and gas excess adjustment in TaikoL2
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Brechtpd
reviewed
Aug 1, 2024
Co-authored-by: Brecht Devos <[email protected]>
|
Update: @Brechtpd I updated this PR such that when (TARGET * ADJUSTMENT_QUOTIENT) changes, we adjust the value of |
Brechtpd
reviewed
Aug 2, 2024
davidtaikocha
added a commit
that referenced
this pull request
Aug 3, 2024
dantaik
changed the title
Brechtpd
approved these changes
Aug 5, 2024
davidtaikocha
approved these changes
Aug 6, 2024
dantaik
added a commit
that referenced
this pull request
Aug 6, 2024
…ustment in TaikoL2 (#17871) Co-authored-by: dantaik <[email protected]> Co-authored-by: Brecht Devos <[email protected]>
davidtaikocha
added a commit
that referenced
this pull request
Aug 6, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes to improve our implementation of the EIP-1559.
1. Refined EIP-1559 Base Fee Calculation
basefee = eth_qty(excess_gas_issued)basefee = eth_qty(excess_gas_issued) / (TARGET * ADJUSTMENT_QUOTIENT)This modification aligns our implementation more closely with Vitalik Buterin's proposal. While both approaches are functional, the new calculation allows for a more gradual adjustment of the base fee.
2. Gas Excess Adjustment in TaikoL2
Implemented a gas excess adjustment mechanism when
TARGET * ADJUSTMENT_QUOTIENTin a block changes to keep the base fee the same. Without this mechanism, the base fee may spike, as demonstrated in thetest_change_of_quotient_and_gipstest.3. Set 5m gas per second
Configured the L2 to issue 5 million gas per second (Ethereum issues 2.5 million gas per second which translates into 2.5*12=30 million block gas target).