-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): improve mainnet gas efficiency with addresses cached #17791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): improve mainnet gas efficiency with addresses cached
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
changed the title
feat(protocol): create L1ProverSet, an optimized version of ProverSet
feat(protocol): create Jul 13, 2024
CachedProverSet
, an optimized version of ProverSet
Brechtpd
approved these changes
Jul 13, 2024
dantaik
changed the title
feat(protocol): create
feat(protocol): improve mainnet gas efficiency with addresses cached
Jul 14, 2024
CachedProverSet
, an optimized version of ProverSet
davidtaikocha
approved these changes
Jul 14, 2024
dantaik
changed the title
feat(protocol): improve mainnet gas efficiency with addresses cached
refactor(protocol): improve mainnet gas efficiency with addresses cached
Jul 14, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized we can cache depending contracts' addresses this way to avoid one SLOAD of the address manager address and another SLOAD of address manager's impl address.
@davidtaikocha After this PR is merged, we need:
MainnetSharedAddressManager
MainnetRollupAddressManager
MainnetTaikoL1
MainnetProverSet
and upgrade our prover sets to use this deployment