Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): refactor TaikoL1 contract #17678

Merged
merged 2 commits into from
Jun 26, 2024
Merged

refactor(protocol): refactor TaikoL1 contract #17678

merged 2 commits into from
Jun 26, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jun 26, 2024

  • move parameter decoding into proveBlock
  • introduce a Local struct in proposeBlock for futhre code change

No logical changes.

@dantaik dantaik marked this pull request as ready for review June 26, 2024 04:10
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jun 26, 2024 •
edited
Loading

refactor(protocol): refactor TaikoL1 contract

Generated at commit: 220cc294ef139f0cd962dc994c8bb02549380ba7

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik enabled auto-merge June 26, 2024 05:20
@dantaik dantaik added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit db6ccdf Jun 26, 2024
4 checks passed
@dantaik dantaik deleted the refactor_taikoL1 branch June 26, 2024 20:45
@taiko-kitty taiko-kitty mentioned this pull request Jun 26, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @Brechtpd @adaki2004