Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): change guardian prover cooldown windows #17590

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jun 14, 2024

Change guardian minority cooldown window from 24 hours to 4 hours. If one guardian is hacked and his proof is incorrect, guardian majority will override it, and guardian majority's cooldown is changed from 1 hour 24 hours so there will be more time for monitoring and necessary actions.

@dantaik dantaik marked this pull request as ready for review June 14, 2024 09:05
@adaki2004
Copy link
Contributor

cc @KorbinianK for bridge UI (message) and @cyberhorsey for relayer queue monitoring time.

@dantaik dantaik added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit cc10b04 Jun 14, 2024
4 checks passed
@dantaik dantaik deleted the turn_tier_config branch June 14, 2024 09:11
Copy link

openzeppelin-code bot commented Jun 14, 2024

feat(protocol): change guardian prover cooldown windows

Generated at commit: 91cfe7135af4f643fc96072d9259001e496f39e8

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@Brechtpd
Copy link
Contributor

If one guardian is hacked and his proof is incorrect, guardian majority will override it

4 hours is certainly on the low side for censorship resistance attacks, the majority of guardians now need to get an L1 transaction included in only 4 hours (each), which is lower than is currently seen as safe as far as I know (though that safe value involves quite a bit of hand waving).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants