-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol): fix seemingly quota issue #17544
Conversation
fix(protocol): fix seemingly quota issue
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
I guess it doesn't matter much because we only use the quotas on L1, but just always using |
I think it could result in a posiisble address clash. When it is a Bridged token on Ethereum (L1), it might be technically possible that a token address from TaikoL2B (e.g.: |
The false-positive revert message is:
QM_OUT_OF_QUOTA
, but the reason is:_token
isaddress(0)
and used before assignment.e.g.: https://etherscan.io/tx/0xaef434ded5c098f42cac27e9d4ecbb028afb672ba1b45429b95a7295752886e1