Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix seemingly quota issue #17544

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

adaki2004
Copy link
Contributor

@adaki2004 adaki2004 commented Jun 10, 2024

The false-positive revert message is: QM_OUT_OF_QUOTA, but the reason is: _token is address(0) and used before assignment.

e.g.: https://etherscan.io/tx/0xaef434ded5c098f42cac27e9d4ecbb028afb672ba1b45429b95a7295752886e1

@adaki2004 adaki2004 requested review from Brechtpd, dantaik, KorbinianK and davidtaikocha and removed request for Brechtpd June 10, 2024 07:41
Copy link

openzeppelin-code bot commented Jun 10, 2024

fix(protocol): fix seemingly quota issue

Generated at commit: 2b3e0a7cfadc1c0a7e74b96b0b532643d2ec943a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@Brechtpd
Copy link
Contributor

I guess it doesn't matter much because we only use the quotas on L1, but just always using _ctoken.addr as the address also seems to make sense to me.

@adaki2004
Copy link
Contributor Author

adaki2004 commented Jun 10, 2024

I guess it doesn't matter much because we only use the quotas on L1, but just always using _ctoken.addr as the address also seems to make sense to me.

I think it could result in a posiisble address clash.
E.g.: Token X is deployed as canonical on TaikoL2B.

When it is a Bridged token on Ethereum (L1), it might be technically possible that a token address from TaikoL2B (e.g.: Token X) has a token already deployed on Ethereum - as same address. So i'd leave it as is.

@dantaik dantaik added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit d083eeb Jun 10, 2024
5 checks passed
@dantaik dantaik deleted the fix_seemingly_quota_issue_but_token_contract branch June 10, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants