Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): change blockMaxProposals from 432_000 to 324000 #17499

Merged
merged 3 commits into from
Jun 6, 2024
Merged

feat(protocol): change blockMaxProposals from 432_000 to 324000 #17499

merged 3 commits into from
Jun 6, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jun 6, 2024

No description provided.

@dantaik dantaik requested a review from Brechtpd June 6, 2024 07:55
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jun 6, 2024 •
edited
Loading

feat(protocol): change ring buffer size from 432_000+512 to 324000+512 (is this a good idea)?

Generated at commit: 3bc8a2ac65a7a04fab8c873ca5672c6b48d8ad46

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik requested a review from davidtaikocha June 6, 2024 14:09
@dantaik dantaik marked this pull request as ready for review June 6, 2024 14:09
@dantaik dantaik enabled auto-merge June 6, 2024 14:09
@dantaik dantaik added this pull request to the merge queue Jun 6, 2024
@dantaik dantaik changed the title feat(protocol): change ring buffer size from 432_000+512 to 324000+512 (is this a good idea)? feat(protocol): change blockMaxProposals from 432_000 to 324000 Jun 6, 2024
Merged via the queue into main with commit c6d184a Jun 6, 2024
5 checks passed
@dantaik dantaik deleted the make-ring_buffer-even_smaller branch June 6, 2024 14:10
@taiko-kitty taiko-kitty mentioned this pull request Jun 6, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @Brechtpd @davidtaikocha