Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow getTransition to be called for all blocks #17268

Merged
merged 5 commits into from
May 20, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented May 20, 2024

This is a feature request to improve the client.

In getBlock, we already verified:

  if (blk_.blockId != _blockId) {
            revert L1_INVALID_BLOCK_ID();
  }

@dantaik dantaik marked this pull request as ready for review May 20, 2024 10:55
Copy link

openzeppelin-code bot commented May 20, 2024

feat(protocol): allow getTransition to be called for all blocks

Generated at commit: 1f08a3bd9472b4d3aae6ef95eed6c528c36e5cb4

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
41
53
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title feat(protocol): allow getTransition to be called for verified blocks feat(protocol): allow getTransition to be called for all blocks May 20, 2024
@dantaik dantaik added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit bca493f May 20, 2024
4 checks passed
@dantaik dantaik deleted the getTransition_check_relaxed branch May 20, 2024 13:11
@YoGhurt111 YoGhurt111 linked an issue May 20, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ubnormal slashing failing to prove
6 participants