Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix vault name and symbol validation bug with more unit tests #17013

Merged
merged 6 commits into from
May 7, 2024

Conversation

adaki2004
Copy link
Contributor

@adaki2004 adaki2004 commented May 6, 2024

  • 1 bug (do not validate inputs for symbol and name)
  • some additional tests
  • fix commenting

Copy link

openzeppelin-code bot commented May 7, 2024

chore(protocol): more vault tests

Generated at commit: 0d741cf9175a90d285e5ac0fbf28584f40075975

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
5
41
50
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@adaki2004
Copy link
Contributor Author

@dantaik @davidtaikocha Could one of you please check out this branch locally, and forge fmt ?
Yesterday i was trying out something so i did a foundryup locally.. Since then the forge fmt command seemingly works differently than in our CICD.. so it seems it is making the forge format check fails here..
Or can we upgrade foundry with foundryup ? My current local version is:
forge 0.2.0 (c486fca 2024-05-06T00:20:07.911403000Z)

@adaki2004 adaki2004 changed the title chore(protocol): more vault tests feat(protocol): small fix + erc20 vault tests May 7, 2024
@adaki2004 adaki2004 requested a review from dantaik May 7, 2024 11:53
@adaki2004 adaki2004 marked this pull request as ready for review May 7, 2024 11:53
@dantaik
Copy link
Contributor

dantaik commented May 7, 2024

@dantaik @davidtaikocha Could one of you please check out this branch locally, and forge fmt ? Yesterday i was trying out something so i did a foundryup locally.. Since then the forge fmt command seemingly works differently than in our CICD.. so it seems it is making the forge format check fails here.. Or can we upgrade foundry with foundryup ? My current local version is: forge 0.2.0 (c486fca 2024-05-06T00:20:07.911403000Z)

No worries about local forge fmt, now modified solidity files will be formatted automatically by a github workflow and all changes done by the formatter will be commited.

Local formats are now temporary, you can safely ignore them.

@dantaik dantaik enabled auto-merge May 7, 2024 12:02
@dantaik dantaik changed the title feat(protocol): small fix + erc20 vault tests feat(protocol): fix vault name and symbol validation issue with more unit tests May 7, 2024
@dantaik dantaik changed the title feat(protocol): fix vault name and symbol validation issue with more unit tests feat(protocol): fix vault name and symbol validation bug with more unit tests May 7, 2024
@dantaik dantaik disabled auto-merge May 7, 2024 12:04
@dantaik dantaik added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 8532b77 May 7, 2024
8 checks passed
@dantaik dantaik deleted the more_vault_tests branch May 7, 2024 12:07
@dantaik dantaik changed the title feat(protocol): fix vault name and symbol validation bug with more unit tests fix(protocol): fix vault name and symbol validation bug with more unit tests May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants