Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): refactor vault code with minor improvement #16797

Merged
merged 8 commits into from
Apr 23, 2024
Merged

refactor(protocol): refactor vault code with minor improvement #16797

merged 8 commits into from
Apr 23, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 22, 2024 •
edited
Loading

No logical changes

  • I unified the params for _handleMessage and uses msg.sender inside the function instead of passing msg.sender as the _user param because msg.sender is already used inside.

  • Taiko Token inherited IERC20MetadataUpgradeable twice

@dantaik dantaik changed the title refactor(protocol): refactor vault code refactor(protocol): refactor vault code with minor improvement Apr 22, 2024
@dantaik dantaik requested review from adaki2004 and Brechtpd April 22, 2024 13:25
@dantaik dantaik marked this pull request as ready for review April 22, 2024 13:25
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 22, 2024 •
edited
Loading

refactor(protocol): refactor vault code with minor improvement

Generated at commit: 716fcb16cf6e257ed83fc13dd468ae1dc6762ba2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
4
39
47
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik enabled auto-merge April 23, 2024 03:27
@dantaik dantaik requested a review from davidtaikocha April 23, 2024 04:11
@dantaik dantaik added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit e12b0fb Apr 23, 2024
7 checks passed
@dantaik dantaik deleted the vault_code_cleanup branch April 23, 2024 06:43
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha