fix(protocol): fix recall not working with bridged tokens

[Brechtpd]

The token passed into receiveToken is always the canonical token, but the recall code checks if bridgedToCanonical[ctoken.addr].addr exists to know if it's a bridged or canonical token, which seems incorrect because it's never a bridged token that is passed in. So the current code does not support recalling on bridged token contracts correctly because all tokens are always seen as canonical.

Previous code:

if (bridgedToCanonical[ctoken.addr].addr != address(0)) {
    IBridgedERC20(ctoken.addr).mint(message.owner, amount);
} else {
    ERC20(ctoken.addr).safeTransfer(message.owner, amount);
}

The first check would always be false because ctoken.addr is always a canonical token and so the bridged path would never be taken. So if indeed the bridged token needs to be used on the chain, it would not work because it would also go through the canonical token path.

I believe the code to transfer the tokens in onMessageRecalled should be the same code that is used in receiveToken with the same token address deduction to know if the bridged variant needs to be used or the canonical one.

There also seems to be no test that tests the ERC20 recall, so I'm trying to add one but it's not working yet because I'm no familiar with the test code. But working on it!

[adaki2004]

LGTM.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
bridge-ui-v2-a6	✅ Ready (Inspect)	Visit Preview	Feb 8, 2024 3:02pm