feat(website): RPC connect Metamask Networks #14070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusWentz
force-pushed
the
metamaskNetworkButtons
branch
from
2efb8a4 to
2f609ea
Compare
dionysuzx
reviewed
Jun 29, 2023
packages/website/components/MetamaskNetworkButton/ConnectToMetamask.tsx
Outdated
Show resolved
Hide resolved
dionysuzx
reviewed
Jun 29, 2023
packages/website/components/MetamaskNetworkButton/ConnectToMetamask.tsx
Outdated
Show resolved
Hide resolved
|
final comment. i see this was added to RPC configuration, which is great. however, i can't help but to feel, is RPC configuration a duplicate of: https://website-lyc4taqy3-taikoxyz.vercel.app/docs/guides/configure-your-wallet ? Should we add it to configure your wallet as well or somehow consolidate the two? Should configure your wallet guide just be a link to RPC configuration? i think any of these are fine, at the least maybe we just add it to configure-your-wallet |
MarcusWentz
force-pushed
the
metamaskNetworkButtons
branch
from
2f609ea to
af40a9d
Compare
|
I think we should redirect the wallet connection page to the RPC connection page based on links on the wallet connection page. |
MarcusWentz
force-pushed
the
metamaskNetworkButtons
branch
from
af40a9d to
b331521
Compare
dantaik
previously approved these changes
Jun 30, 2023
dionysuzx
approved these changes
Jun 30, 2023
dantaik
approved these changes
Jul 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified:
#14068
to not have the Metamask pnpm package to handle the
object.
Instead
is used to keep things simple for package dependencies.