Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status-page): use ttko from env #13998

Merged
merged 2 commits into from
Jun 16, 2023
Merged

fix(status-page): use ttko from env #13998

merged 2 commits into from
Jun 16, 2023

Conversation

dionysuzx
Copy link
Collaborator

No description provided.

@davidtaikocha
Copy link
Member

image emm and btw shall we change this color to green?

dantaik
dantaik previously approved these changes Jun 15, 2023
@dionysuzx
Copy link
Collaborator Author

image emm and btw shall we change this color to green?

can you check this commit / the logic I'm commenting out? bd38c62

I'm wondering, do we really want to return green all the time here or should we tweak the conditions for green/yellow/red?

@cyberhorsey
Copy link
Contributor

image emm and btw shall we change this color to green?

can you check this commit / the logic I'm commenting out? bd38c62

I'm wondering, do we really want to return green all the time here or should we tweak the conditions for green/yellow/red?

It doesn't matter, this status page will be gone in a week and replaces by a block scout integration.

@dionysuzx dionysuzx enabled auto-merge June 15, 2023 21:09
@dionysuzx dionysuzx requested a review from dantaik June 15, 2023 21:09
@dionysuzx dionysuzx added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit 2c83f3b Jun 16, 2023
@dionysuzx dionysuzx deleted the fix-ttko branch June 16, 2023 03:01
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants