Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): inform connect when adding erc20 #13900

Merged
merged 13 commits into from
Jun 6, 2023

Conversation

jscriptcoder
Copy link
Contributor

No need to waste user's time showing them something they can't use. Show a message if they try to add an ERC20 token without being connected

@jscriptcoder jscriptcoder self-assigned this Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #13900 (8ae2c8c) into main (1abc3ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13900   +/-   ##
=======================================
  Coverage   51.55%   51.55%           
=======================================
  Files         144      144           
  Lines        3798     3798           
  Branches      333      333           
=======================================
  Hits         1958     1958           
  Misses       1726     1726           
  Partials      114      114           
Flag Coverage Δ *Carryforward flag
bridge-ui 94.31% <ø> (ø)
eventindexer 77.28% <ø> (ø) Carriedforward from 8a6ff92
protocol 0.00% <ø> (ø) Carriedforward from 8a6ff92
relayer 59.57% <ø> (ø) Carriedforward from 8a6ff92
ui 100.00% <ø> (ø) Carriedforward from 8a6ff92

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jscriptcoder jscriptcoder marked this pull request as ready for review June 6, 2023 17:49
@jscriptcoder jscriptcoder added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit 2b21f59 Jun 6, 2023
@jscriptcoder jscriptcoder deleted the inform_connect_when_adding_erc20 branch June 6, 2023 18:13
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
dantaik pushed a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants