feat(protocol): Change back token decimals #13707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaki2004
changed the title
|
We can change to 18 and uint256 later, but requires some changes and in case we need to deploy testnet soon, better to stick to it. |
Brechtpd
approved these changes
May 4, 2023
davidtaikocha
approved these changes
May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change back token decimal settings to 8 from 18, because it affects not only tests but the code itself.
uint64range of the baseFee currently implies some limitations, so decimal 8 would perfectly fit in but 18 needs to involve some other changes.