Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventindexer): ProposeEvents filtering, API exposing, and getting count by address/event + tests #13624

Merged
merged 12 commits into from
Apr 20, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Apr 19, 2023

This Pr enhances functionality in our eventindexer to prepare for alpha-3.

It:

  • adds BlockProposed events filtering
  • exposes API endpoint for status page to show unique block proposed addresses
  • adds proposed blocks to status page, consuming above endpoint, and adding modal to view
  • exposes API endpoint for individual addresses, to see how many blocks they have proposed or proven (which will be used for the local node status page coming up in a future PR)
  • adds large missing test coverage, since this service was written quickly for alpha-2 to stem the flow of "How many different people have proven blocks" question, by adding blockProven to status page.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #13624 (a53dff4) into main (43247d3) will increase coverage by 2.19%.
The diff coverage is 73.91%.

❗ Current head a53dff4 differs from pull request most recent head 897a72f. Consider uploading reports for the commit 897a72f to get more accurate results

@@            Coverage Diff             @@
##             main   #13624      +/-   ##
==========================================
+ Coverage   36.67%   38.86%   +2.19%     
==========================================
  Files         127      133       +6     
  Lines        3815     4006     +191     
  Branches      508      504       -4     
==========================================
+ Hits         1399     1557     +158     
- Misses       2324     2345      +21     
- Partials       92      104      +12     
Flag Coverage Δ *Carryforward flag
bridge-ui 94.55% <ø> (+0.54%) ⬆️ Carriedforward from c011f84
eventindexer 82.08% <73.91%> (∅)
protocol 0.00% <ø> (ø) Carriedforward from c011f84
relayer 62.53% <ø> (ø) Carriedforward from c011f84
ui 100.00% <ø> (ø) Carriedforward from c011f84

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/eventindexer/repo/event.go 69.38% <71.42%> (ø)
packages/eventindexer/http/get_unique_proposers.go 72.72% <72.72%> (ø)
...ventindexer/http/get_count_by_address_and_event.go 75.00% <75.00%> (ø)
packages/eventindexer/http/routes.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 839a0be Apr 20, 2023
@davidtaikocha davidtaikocha deleted the event_indexer_propose_events branch April 20, 2023 14:15
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants