Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): improve notice modal #13530

Merged
merged 10 commits into from
Apr 4, 2023
Merged

fix(bridge-ui): improve notice modal #13530

merged 10 commits into from
Apr 4, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Apr 3, 2023

Improved <NoticeModal />, exposing API so individual transactions can open the modal and store the opt-out selection for each one.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #13530 (2bf908e) into main (02feb58) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13530      +/-   ##
==========================================
+ Coverage   36.11%   36.13%   +0.01%     
==========================================
  Files         124      124              
  Lines        3777     3778       +1     
  Branches      502      502              
==========================================
+ Hits         1364     1365       +1     
  Misses       2321     2321              
  Partials       92       92              
Flag Coverage Δ *Carryforward flag
bridge-ui 94.20% <100.00%> (+0.01%) ⬆️
eventindexer ∅ <ø> (∅) Carriedforward from 9ab8a99
protocol 0.00% <ø> (ø) Carriedforward from 9ab8a99
relayer 62.53% <ø> (ø) Carriedforward from 9ab8a99
ui 100.00% <ø> (ø) Carriedforward from 9ab8a99

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/storage/StorageService.ts 95.87% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cyberhorsey
cyberhorsey previously approved these changes Apr 3, 2023
@cyberhorsey cyberhorsey enabled auto-merge April 4, 2023 01:58
@cyberhorsey cyberhorsey added this pull request to the merge queue Apr 4, 2023
Merged via the queue into main with commit 3944ca8 Apr 4, 2023
@cyberhorsey cyberhorsey deleted the improve_notice_modal branch April 4, 2023 02:25
@github-actions github-actions bot mentioned this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants