-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-ui): more informative processing fee #13488
feat(bridge-ui): more informative processing fee #13488
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13488 +/- ##
==========================================
- Coverage 36.14% 36.11% -0.04%
==========================================
Files 124 124
Lines 3779 3777 -2
Branches 502 502
==========================================
- Hits 1366 1364 -2
Misses 2321 2321
Partials 92 92
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
packages/bridge-ui/src/components/Transactions/MessageStatusTooltip.svelte
Outdated
Show resolved
Hide resolved
It's failing some "unused import" lints as well but couldn't tag them in review |
…r-inform-the-user
It's not an error, but a warning. In any case I got rid of some of them... ESLint errors and warnings are getting addressed in another PR
@jscriptcoder vs |
This PR addresses the following suggestions: #13476. Besides that there a few more things:
any
. I added the correct types for this field.BigNumber
type, which I found it unnecessary. They can simply benumber
.NoticeModal
, which presents the user with some message and the option to not seeing it again.Transaction
component. Still a lot to do here. I believe it's quite bloated. We could perfectly extract a lot of logic outside and also up in its parent such as claiming and releasing functions.