Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): disable contracts as msg.sender #13206

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 23, 2023

I'm being cautious here as many hacks are done by creating a msg-sending contract to interact with the target contract.

This PR enforce all msg.senders for proposeBlock, proveBlock, and verifyBlocks must be EOA, but doesn't prevent prover address to be contracts to receive rewards.

@dantaik dantaik marked this pull request as ready for review February 23, 2023 01:25
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #13206 (6dea3da) into main (8908d8d) will increase coverage by 0.10%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main   #13206      +/-   ##
==========================================
+ Coverage   60.05%   60.16%   +0.10%     
==========================================
  Files         115      115              
  Lines        3450     3454       +4     
  Branches      468      469       +1     
==========================================
+ Hits         2072     2078       +6     
+ Misses       1291     1289       -2     
  Partials       87       87              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 8908d8d
protocol 51.11% <62.50%> (+0.21%) ⬆️
relayer 65.15% <ø> (ø) Carriedforward from 8908d8d
ui 100.00% <ø> (ø) Carriedforward from 8908d8d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 36.20% <62.50%> (+4.72%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik enabled auto-merge February 23, 2023 02:26
@dantaik dantaik added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit 66316e9 Feb 23, 2023
@dantaik dantaik deleted the msg_sender_not_contracts branch February 23, 2023 03:41
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants