-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): optimize gas for processMessage & retryMessage #13181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Bridge tests.
…taiko-mono into gas_optimize_process_message
cyberhorsey
changed the title
feat(bridge): Gas optimize processmessage, retrymessage
feat(protocol): Gas optimize processmessage, retrymessage
Feb 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #13181 +/- ##
==========================================
- Coverage 61.61% 61.16% -0.46%
==========================================
Files 118 117 -1
Lines 3478 3409 -69
Branches 491 466 -25
==========================================
- Hits 2143 2085 -58
+ Misses 1250 1244 -6
+ Partials 85 80 -5
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…gas optimization. down to 612000
…taiko-mono into gas_optimize_process_message
dantaik
reviewed
Mar 7, 2023
dantaik
reviewed
Mar 7, 2023
dantaik
reviewed
Mar 8, 2023
dantaik
reviewed
Mar 8, 2023
dantaik
previously approved these changes
Mar 8, 2023
davidtaikocha
previously approved these changes
Mar 8, 2023
dantaik
approved these changes
Mar 9, 2023
davidtaikocha
approved these changes
Mar 9, 2023
dantaik
approved these changes
Mar 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gas costs can reach above 2 million for a retryMessage call, and 1.5 million for a processMessage call, if it is ERC20 + deploying a contract. Can reach 1.4 million without deploying.
Gas cost is ~800,000-900,000 if sendEther.
Current work so far on this draft:
sendEther: 560000~