Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): use prevrandao for L2 mixHash #13157

Merged
merged 22 commits into from
Feb 16, 2023
Merged

fix(protocol): use prevrandao for L2 mixHash #13157

merged 22 commits into from
Feb 16, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 15, 2023

No description provided.

davidtaikocha
davidtaikocha previously approved these changes Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #13157 (d19b23e) into main (4f7ab64) will increase coverage by 0.03%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##             main   #13157      +/-   ##
==========================================
+ Coverage   60.95%   60.98%   +0.03%     
==========================================
  Files         115      115              
  Lines        3391     3394       +3     
  Branches      460      463       +3     
==========================================
+ Hits         2067     2070       +3     
  Misses       1241     1241              
  Partials       83       83              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 0bb361b
protocol 51.88% <47.61%> (+0.08%) ⬆️
relayer 66.06% <ø> (ø) Carriedforward from 0bb361b
ui 100.00% <ø> (ø) Carriedforward from 0bb361b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 32.69% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 6.57% <0.00%> (+0.16%) ⬆️
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.84% <ø> (ø)
packages/protocol/contracts/bridge/EtherVault.sol 76.19% <ø> (ø)
...s/protocol/contracts/bridge/libs/LibBridgeData.sol 100.00% <ø> (ø)
...es/protocol/contracts/test/libs/TestLibProving.sol 0.00% <0.00%> (ø)
...s/protocol/contracts/thirdparty/AddressManager.sol 100.00% <ø> (ø)
...protocol/contracts/thirdparty/ERC20Upgradeable.sol 61.44% <ø> (ø)
packages/protocol/contracts/bridge/TokenVault.sol 51.08% <55.55%> (+0.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from addtl_int_tests to main February 16, 2023 12:03
@dantaik dantaik requested a review from Brechtpd February 16, 2023 15:08
@dantaik dantaik added this pull request to the merge queue Feb 16, 2023
Merged via the queue into main with commit 93daca4 Feb 16, 2023
@dantaik dantaik deleted the fix_mixHash branch February 16, 2023 19:33
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants