Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(cmd): default unit for all related flags / logs #729

Merged
merged 11 commits into from
Apr 19, 2024
Merged

feat(cmd): default unit for all related flags / logs #729

merged 11 commits into from
Apr 19, 2024

Conversation

YoGhurt111
Copy link
Contributor

@YoGhurt111 YoGhurt111 commented Apr 18, 2024 •
edited
Loading

Flag name change

  • backoff.maxRetrys => backoff.maxRetries
  • tierFee.pricebump => tierFee.priceBump
  • txpool.locals => txPool.locals
  • txpool.localsOnly => txPool.localsOnly
  • txpool.maxTxListsPerEpoch => txPool.maxTxListsPerEpoch
  • raiko.hostEndpoint => raiko.host
  • raiko.l1Endpoint => raiko.l1
  • raiko.l1BeaconEndpoint => raiko.l1Beacon
  • raiko.l2Endpoint => raiko.l2
  • http.port => prover.port

Unit change from wei

  • tierFee.optimistic unit: gwei
  • tierFee.sgx unit: gwei
  • prover.minEthBalance unit: ether
  • prover.minTaikoTokenBalance unit: ether
  • prover.allowance unit: ether

@YoGhurt111 YoGhurt111 marked this pull request as draft April 18, 2024 07:02
@YoGhurt111 YoGhurt111 linked an issue Apr 18, 2024 that may be closed by this pull request
feat(cmd): use gwei as default unit for all related flags / logs #703
Closed
davidtaikocha
davidtaikocha reviewed Apr 18, 2024
View reviewed changes
cmd/flags/common.go Outdated Show resolved Hide resolved
cmd/flags/prover.go Outdated Show resolved Hide resolved
cmd/flags/prover.go Outdated Show resolved Hide resolved
pkg/utils/eth.go Outdated Show resolved Hide resolved
pkg/utils/eth.go Outdated Show resolved Hide resolved
@mask-pp
Copy link
Contributor

mask-pp commented Apr 19, 2024

Can you support a sample .env file?

@davidtaikocha
Copy link
Member

Can you support a sample .env file?

Can't see there is an example .env file in go-ethereum or optimism, don't think we need to neither, maybe adding a doc for that on our website is enough?

@davidtaikocha
Copy link
Member

Can you support a sample .env file?

image

Just checked the output of --help, all env names are there.

@YoGhurt111 YoGhurt111 marked this pull request as ready for review April 19, 2024 03:30
@YoGhurt111 YoGhurt111 enabled auto-merge (squash) April 19, 2024 03:33
mask-pp
mask-pp reviewed Apr 19, 2024
View reviewed changes
cmd/flags/prover.go Outdated Show resolved Hide resolved
cmd/flags/prover.go Outdated Show resolved Hide resolved
@YoGhurt111 YoGhurt111 merged commit ec7ba9d into main Apr 19, 2024
5 checks passed
@YoGhurt111 YoGhurt111 deleted the default-unit branch April 19, 2024 07:08
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Merged
davidtaikocha added a commit that referenced this pull request Apr 21, 2024
@YoGhurt111 @davidtaikocha
feat(cmd): default unit for all related flags / logs (#729)
b6c651c 
Co-authored-by: David <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mask-pp mask-pp mask-pp left review comments

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@RogerLamTd RogerLamTd Awaiting requested review from RogerLamTd

Assignees
No one assigned
Labels
area.client type.enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cmd): use gwei as default unit for all related flags / logs
3 participants
@YoGhurt111 @mask-pp @davidtaikocha