Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(all): disable no beacon client seen warning #279

Merged
merged 31 commits into from
Jun 15, 2023

Conversation

RogerLamTd
Copy link
Contributor

@RogerLamTd RogerLamTd commented Jun 9, 2023

By on interval calling ExchangeTransitionConfigurationV1 through the engine, lastTransitionUpdate gets updated and the beacon warning is consequently never triggered. Default TransitionConfiguration used according to execution api specs

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #279 (7f9fc17) into main (ebf3162) will increase coverage by 0.73%.
The diff coverage is 73.13%.

❗ Current head 7f9fc17 differs from pull request most recent head ed5e749. Consider uploading reports for the commit ed5e749 to get more accurate results

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   51.31%   52.05%   +0.73%     
==========================================
  Files          36       36              
  Lines        3788     3840      +52     
==========================================
+ Hits         1944     1999      +55     
+ Misses       1589     1584       -5     
- Partials      255      257       +2     
Impacted Files Coverage Δ
pkg/rpc/engine.go 66.66% <0.00%> (-22.23%) ⬇️
prover/proof_producer/zkevm_rpcd_producer.go 27.77% <0.00%> (ø)
prover/proof_submitter/util.go 29.50% <0.00%> (ø)
pkg/chain_iterator/block_batch_iterator.go 50.26% <33.33%> (-0.28%) ⬇️
pkg/rpc/client.go 49.25% <77.77%> (+4.09%) ⬆️
driver/driver.go 65.82% <96.42%> (+6.12%) ⬆️
driver/config.go 76.00% <100.00%> (+1.00%) ⬆️
pkg/rpc/dial.go 53.96% <100.00%> (ø)
pkg/rpc/utils.go 20.31% <100.00%> (ø)
proposer/config.go 59.25% <100.00%> (+0.76%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

driver/driver.go Outdated Show resolved Hide resolved
@RogerLamTd RogerLamTd requested a review from davidtaikocha June 14, 2023 02:03
@davidtaikocha davidtaikocha merged commit cdabcac into main Jun 15, 2023
@davidtaikocha davidtaikocha deleted the disablebeaconwarning branch June 15, 2023 06:19
davidtaikocha added a commit that referenced this pull request Jun 15, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants