Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "project_attr" feature and always enable #[project] attribute #82

Closed
taiki-e opened this issue Sep 9, 2019 · 0 comments · Fixed by #94
Closed

Remove "project_attr" feature and always enable #[project] attribute #82

taiki-e opened this issue Sep 9, 2019 · 0 comments · Fixed by #94
Labels
A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) breaking-change This proposes a breaking change
Milestone
v0.4

Comments

@taiki-e
Copy link
Owner

taiki-e commented Sep 9, 2019 •
edited
Loading

This feature is now much more convenient than it was when it was introduced. This is necessary when using enums and will be more convenient if #85 and #81 are merged. I feel that it may make sense to enable it by default.

Also, one of the reasons why this is an optional feature was that it had some bugs, but I think most of these were fixed in #38 and #52. So, if we enable it by default, we can also remove the feature gate.
@taiki-e taiki-e added this to the v0.4 milestone Sep 9, 2019
@taiki-e taiki-e mentioned this issue Sep 18, 2019
Merged
@taiki-e taiki-e changed the title Remove "project_attr" feature and enable #[project] attribute by default Remove "project_attr" feature and always enable #[project] attribute Sep 18, 2019
@bors bors bot closed this as completed in 68e783d Sep 19, 2019
@taiki-e taiki-e added breaking-change This proposes a breaking change A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) labels Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) breaking-change This proposes a breaking change
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Remove "project_attr" feature and always enable #[project] attribute taiki-e/pin-project
1 participant
@taiki-e