Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to clippy have broken CI on Tokio #46

Closed
Darksonn opened this issue Jan 9, 2021 · 3 comments · Fixed by #47
Closed

Changes to clippy have broken CI on Tokio #46

Darksonn opened this issue Jan 9, 2021 · 3 comments · Fixed by #47
Labels
C-bug Category: related to a bug.

Comments

@Darksonn
Copy link

Darksonn commented Jan 9, 2021

The Tokio master branch failed with the following error:

error: unknown clippy lint: clippy::ref_option_ref
   --> tokio/src/task/local.rs:150:1
    |
150 | / pin_project! {
151 | |     #[derive(Debug)]
152 | |     struct RunUntil<'a, F> {
153 | |         local_set: &'a LocalSet,
...   |
156 | |     }
157 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
@taiki-e taiki-e added the C-bug Category: related to a bug. label Jan 9, 2021
@taiki-e
Copy link
Owner

taiki-e commented Jan 9, 2021

Thanks for the report! This is definitely clippy's bug (unknown_clippy_lints shouldn't warn of code generated by external macros), but I will fix it soon on the pin-project-lite side. (the same issue as taiki-e/pin-project#303)

@taiki-e
Copy link
Owner

taiki-e commented Jan 9, 2021

Published 0.2.3 which fixes this issue.

@Darksonn
Copy link
Author

Darksonn commented Jan 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants