Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find-crate 0.7.0 release #22

Open
str4d opened this issue Jan 7, 2024 · 1 comment
Open

find-crate 0.7.0 release #22

str4d opened this issue Jan 7, 2024 · 1 comment

Comments

@str4d
Copy link

str4d commented Jan 7, 2024

There has been significant and consistent development on this crate since v0.6.3 was published in January 2021. In particular, find-crate 0.6.3 depends on toml 0.5.2, while current HEAD depends on toml 0.8. It would be nice to have a new release to enable crates like i18n-embed-impl (and its downstream users) to de-duplicate their toml dependencies. Are there any blockers remaining on a new release?

@taiki-e
Copy link
Owner

taiki-e commented Feb 3, 2024

I'm hesitant to release a version that depends on toml 0.6+ because of increased dependencies and compile time, frequent breaking releases, and aggressive MSRV bumping done even when not needed, since toml 0.6.

Frequent breaking releases are not a problem if we are not using toml on the public API, and aggressive MSRV bumps are not much of a concern for a binary crate that does not care about high MSRV, but unfortunately this crate is neither.

So I would like to at least remove toml crate from the public APIs before the next breaking release.

It is currently used by the following two public APIs, and it would be reasonable to change the former to an opaque error type and the latter to an API that takes &str.

Toml(toml::de::Error),

pub fn from_toml(manifest: Table) -> Self {

I have heard that recent versions have improved somewhat with regard to compile time, but moving to a crate like basic-toml may be a more reasonable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants