Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default profraw file name in Rust 1.65 #204

Closed
wesleywiser opened this issue Aug 15, 2022 · 2 comments
Closed

New default profraw file name in Rust 1.65 #204

wesleywiser opened this issue Aug 15, 2022 · 2 comments

Comments

@wesleywiser
Copy link

Hi @taiki-e!

I just wanted to give you a heads up that we are changing the default profraw file name in Rust 1.65 (rust-lang/rust#100384). Looking over your crate, I don't believe this will affect you since you explicitly set LLVM_PROFILE_FILE but wanted to let you know anyway.

@taiki-e
Copy link
Owner

taiki-e commented Aug 15, 2022

Thanks for the heads up!

As you mentioned, we set LLVM_PROFILE_FILE so it would not be affected.

let llvm_profile_file = cx.ws.target_dir.join(format!("{}-%p-%m.profraw", cx.ws.name));

However, rust-lang/rust#100384 may help avoid the problem of profiles being ignored when LLVM_PROFILE_FILE is removed.

// If you remove the LLVM_PROFILE_FILE environment variable,
// no profile will be collected.
assert!(Command::new(env!("CARGO_BIN_EXE_bin_crate"))
.arg("2")
.env_remove("LLVM_PROFILE_FILE")
.status()
.unwrap()
.success());

EDIT: It will not help to fix the above problem because the profiles are output in different directories than the one we use.

@taiki-e
Copy link
Owner

taiki-e commented Sep 6, 2022

Closing -- We are not affected by this issue.

@taiki-e taiki-e closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants