Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When '--all' is executed in subcrate, the command does not apply to other crates in the workspace #11

Closed
taiki-e opened this issue Nov 1, 2019 · 1 comment · Fixed by #17
Assignees
Labels
A-workspace Area: cargo workspace (--workspace, --exclude, --package, etc.) C-bug Category: related to a bug.
Milestone

Comments

@taiki-e
Copy link
Owner

taiki-e commented Nov 1, 2019

This is because current cargo-hack doesn't try to find the root manifest after finding the current package's manifest. (i.e., current cargo-hack always handles the current manifest as a root manifest.)

// TODO: The current cargo-hack doesn't try to find the root manifest
// after finding the current package's manifest.
// https://github.com/taiki-e/cargo-hack/issues/11
let root_dir = current_manifest.dir();

@taiki-e taiki-e added C-bug Category: related to a bug. C-enhancement Category: A new feature or an improvement for an existing one labels Nov 1, 2019
@taiki-e
Copy link
Owner Author

taiki-e commented Nov 2, 2019

'--package' flag has the same issue.

@taiki-e taiki-e self-assigned this Nov 9, 2019
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Nov 9, 2019
@taiki-e taiki-e added this to the v0.3 milestone Nov 9, 2019
@bors bors bot closed this as completed in #17 Nov 10, 2019
@bors bors bot closed this as completed in a32a532 Nov 10, 2019
@taiki-e taiki-e added the A-workspace Area: cargo workspace (--workspace, --exclude, --package, etc.) label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: cargo workspace (--workspace, --exclude, --package, etc.) C-bug Category: related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant