fix(legacy): InputDateTime validators not triggered when value change
#9838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit 1fd78ce): https://taiga-previews-demo--pr9838-mdlufy-legacy-input-date-t-7xcv2u3g.web.app (expires Wed, 27 Nov 2024 17:04:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +44B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test results
Details
Failed testschromium › tests/legacy/input-date-time/input-date-time.pw.spec.ts › InputDateTime › Examples › With validator: enter incomplete date -> validator error Flaky testschromium › tests/demo/demo.pw.spec.ts › Demo › /charts/legend-item |
mdlufy
commented
Nov 26, 2024
projects/demo-playwright/tests/legacy/input-date-time/input-date-time.pw.spec.ts
Show resolved
Hide resolved
mdlufy
requested review from
MarsiBarsi,
waterplea,
nsbarsukov and
vladimirpotekhin
and removed request for
a team
mdlufy
changed the title
InputDateTime validators not triggered when value changeInputDateTime validators not triggered when value change
splincode
approved these changes
Nov 26, 2024
nsbarsukov
reviewed
Nov 26, 2024
projects/demo-playwright/tests/legacy/input-date-time/input-date-time.pw.spec.ts
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-time/examples/7/index.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-time/index.html
Outdated
Show resolved
Hide resolved
mdlufy
force-pushed
the
mdlufy/legacy/input-date-time
branch
from
dc37ea8
to
e816649
Compare
nsbarsukov
approved these changes
Nov 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9839