Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): adds size harness for button #8760

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

mohan-mu
Copy link
Contributor

Partially implements #476

Copy link

lumberjack-bot bot commented Aug 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (43c0ebb) to head (1a363c3).
Report is 1462 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8760      +/-   ##
==========================================
- Coverage   70.19%   66.77%   -3.42%     
==========================================
  Files        1460     1178     -282     
  Lines       15934    15165     -769     
  Branches     2292     2162     -130     
==========================================
- Hits        11185    10127    -1058     
- Misses       4369     4846     +477     
+ Partials      380      192     -188     
Flag Coverage Δ
summary 66.77% <ø> (-3.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Aug 30, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
282.33KB +10%
demo/browser/vendor.(hash).js
216.46KB +10%
demo/browser/runtime.(hash).js
42KB +10%
demo/browser/styles.(hash).css
11.61KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.9MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

projects/testing/core/button.harness.ts Outdated Show resolved Hide resolved
@splincode splincode enabled auto-merge (squash) August 30, 2024 09:34
@splincode splincode merged commit 71e654f into taiga-family:main Aug 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants