Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add harness tests for tag component #2746

Merged
merged 6 commits into from
Oct 14, 2022

Conversation

zarghamkhandev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Partially implements #476

Does this PR introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 61.77% // Head: 61.77% // No change to project coverage 👍

Coverage data is based on head (2b7cb28) compared to base (b7d703d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2746   +/-   ##
=======================================
  Coverage   61.77%   61.77%           
=======================================
  Files        1465     1465           
  Lines       17333    17333           
  Branches     2353     2353           
=======================================
  Hits        10708    10708           
  Misses       6186     6186           
  Partials      439      439           
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.38% <ø> (ø)
addon-editor 53.20% <ø> (ø)
addon-mobile 61.68% <ø> (ø)
addon-table 64.43% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.30% <ø> (ø)
core 76.26% <ø> (ø)
kit 73.62% <ø> (ø)
summary 61.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 8, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode
Copy link
Member

@zarghamkhandev please, rebase with main branch

@zarghamkhandev
Copy link
Contributor Author

@splincode done ✅

@bundlemon
Copy link

bundlemon bot commented Oct 13, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
317.68KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
33.76KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.15MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode
Copy link
Member

image

@splincode
Copy link
Member

image

@waterplea waterplea merged commit fb12283 into taiga-family:main Oct 14, 2022
@well-done-bot
Copy link

well-done-bot bot commented Oct 14, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants