Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add component harness test for primitive-textfield component #2584

Merged

Conversation

zarghamkhandev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Partially implements #476

Does this PR introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Base: 56.67% // Head: 56.28% // Decreases project coverage by -0.38% ⚠️

Coverage data is based on head (410ba83) compared to base (f938d49).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
- Coverage   56.67%   56.28%   -0.39%     
==========================================
  Files         956      956              
  Lines        9237     9237              
  Branches     1894     1894              
==========================================
- Hits         5235     5199      -36     
- Misses       3591     3621      +30     
- Partials      411      417       +6     
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.12% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 60.98% <ø> (-1.89%) ⬇️
kit 61.50% <ø> (ø)
summary 56.28% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...jects/core/components/tooltip/tooltip.component.ts 16.66% <0.00%> (-58.34%) ⬇️
...ts/core/directives/hint/hint-describe.directive.ts 11.76% <0.00%> (-47.06%) ⬇️
...cts/core/directives/hint/hint-options.directive.ts 60.00% <0.00%> (-40.00%) ⬇️
...s/textfield-controller/textfield-size.directive.ts 80.00% <0.00%> (-20.00%) ⬇️
...extfield-controller/textfield-cleaner.directive.ts 80.00% <0.00%> (-20.00%) ⬇️
...ld-controller/textfield-label-outside.directive.ts 80.00% <0.00%> (-20.00%) ⬇️
...jects/core/directives/wrapper/wrapper.directive.ts 63.63% <0.00%> (-18.19%) ⬇️
...imitive-textfield/primitive-textfield.component.ts 64.28% <0.00%> (-11.43%) ⬇️
...eld/value-decoration/value-decoration.component.ts 80.95% <0.00%> (-9.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov added the community contribution This issue was closed by a PR from the community label Sep 16, 2022
@nsbarsukov
Copy link
Member

@zarghamkhandev Could you rebase you branch and solve conflicts, please ?

@zarghamkhandev
Copy link
Contributor Author

@waterplea this could be merged

@waterplea waterplea merged commit 40e2a91 into taiga-family:main Sep 27, 2022
@well-done-bot
Copy link

well-done-bot bot commented Sep 27, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

4 participants