Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): TuiTabsWithMore should share TuiActiveZone for nested dropdowns inside more-section #9714

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Nov 7, 2024

Fixes #9486
Fixes #5272
Fixes #837

@nsbarsukov nsbarsukov self-assigned this Nov 7, 2024
Copy link

lumberjack-bot bot commented Nov 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Visit the preview URL for this PR (updated for commit 6b7875c):

https://taiga-previews--pr9714-tabs-with-more-fix-fibsh87e.web.app

(expires Fri, 08 Nov 2024 12:26:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Nov 7, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
299.27KB (+15B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.04KB +10%
demo/browser/runtime.(hash).js
43.51KB +10%
demo/browser/styles.(hash).css
19.6KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +15B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.25MB (-38B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov changed the title [WIP] fix(kit): TuiTabsWithMore should share TuiActiveZone for nested dropdowns inside more-section fix(kit): TuiTabsWithMore should share TuiActiveZone for nested dropdowns inside more-section Nov 7, 2024
@nsbarsukov nsbarsukov marked this pull request as ready for review November 7, 2024 12:43
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 7, 2024 12:43
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 7, 2024 12:43
@splincode splincode merged commit f7c8fd5 into main Nov 11, 2024
25 of 27 checks passed
@splincode splincode deleted the tabs-with-more-fix branch November 11, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants